Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont try to use the scheduler ring when a downstream url is configured #4635

Merged
merged 1 commit into from
Nov 3, 2021
Merged

dont try to use the scheduler ring when a downstream url is configured #4635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/loki/config_wrapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,11 @@ func (c *ConfigWrapper) ApplyDynamicConfig() cfg.Source {
return errors.New("dst is not a Loki ConfigWrapper")
}

// If nobody has defined any frontend address or scheduler address
// If nobody has defined any frontend address, scheduler address, or downstream url
// we can default to using the query scheduler ring for scheduler discovery.
if r.Worker.FrontendAddress == "" &&
r.Worker.SchedulerAddress == "" &&
r.Frontend.DownstreamURL == "" &&
r.Frontend.FrontendV2.SchedulerAddress == "" {
r.QueryScheduler.UseSchedulerRing = true
}
Expand Down