Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply better defaults when boltdb shipper is being used #4508

Merged
merged 7 commits into from
Oct 21, 2021
Merged

Apply better defaults when boltdb shipper is being used #4508

merged 7 commits into from
Oct 21, 2021

Conversation

trevorwhitney
Copy link
Collaborator

@trevorwhitney trevorwhitney commented Oct 20, 2021 •
edited
Loading

What this PR does / why we need it:

This PR adds logic to the ApplyDynamicConfig function that will pick better defaults for chunk storage configuration and compactor storage configuration. If the current schema is using BoltDB, it will set the default shared_store for both boltdb.shipper.shared-store and boltdb.shipper.compactor.shared-store to the value of the current schema's object-store.

Checklist

  • Documentation added
  • Tests updated

@trevorwhitney trevorwhitney requested a review from a team as a code owner October 20, 2021 20:34
@trevorwhitney trevorwhitney changed the title Apply better defaults for boltdb shipper is being used Apply better defaults when boltdb shipper is being used Oct 20, 2021
Base automatically changed from common-object-store to main October 21, 2021 17:58
owen-d
owen-d reviewed Oct 21, 2021
View reviewed changes
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request then LGTM

pkg/loki/config_wrapper.go Show resolved Hide resolved
@owen-d owen-d merged commit 6f28a5d into main Oct 21, 2021
@owen-d owen-d deleted the boltdb-defaults branch October 21, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trevorwhitney @owen-d