Promtail: add static labels in stage #4495
Conversation
|
|
71f8f70 to
f04a4cb
Compare
|
@dannykopping I am not able to figure out if build failed because of my changes. |
|
Restarted the build, let's see |
@dannykopping Can you please review it? |
Yes, I will review it as soon as I have some time - it may take a few days unfortunately. |
| return errors.New(ErrEmptyStaticLabelStageConfig) | ||
| } | ||
| for labelName, labelSrc := range c { | ||
| if !model.LabelName(labelName).IsValid() { |
There was a problem hiding this comment.
Can we also validate the label value ?
There was a problem hiding this comment.
I have added label-value validation in Process() function.
| } | ||
| // If no label source was specified, use the key name | ||
| if labelSrc == nil || *labelSrc == "" { | ||
| lName := labelName |
There was a problem hiding this comment.
I just took the idea from labels.go.
If no label-value is specified, we can just use the label-name as label-value.
There was a problem hiding this comment.
I think we should keep this explicit. If folks want a label/value combination of the same value, they should define it as such.
There was a problem hiding this comment.
Please remove this @sankalp-r
There was a problem hiding this comment.
@dannykopping How should we handle the case when labelSrc is nil ?
It will cause error if we try to access nil value in Process function.
There was a problem hiding this comment.
We should skip the label in that case IMO
There was a problem hiding this comment.
@dannykopping Added skip logic in the Process function.
1a83bac to
59fcecf
Compare
59fcecf to
12d3ac0
Compare
I have added documentation section. Please have a look. |
There was a problem hiding this comment.
@sankalp-r this looks great, thanks for your contribution!
I've added a few minor spelling corrections, and added to the question asked by Cyril. Once we have all those fixed up this one will be good to merge 👍
| } | ||
| // If no label source was specified, use the key name | ||
| if labelSrc == nil || *labelSrc == "" { | ||
| lName := labelName |
There was a problem hiding this comment.
I think we should keep this explicit. If folks want a label/value combination of the same value, they should define it as such.
12d3ac0 to
f6ae843
Compare
Done the changes, please have a look. |
| } | ||
| // If no label source was specified, use the key name | ||
| if labelSrc == nil || *labelSrc == "" { | ||
| lName := labelName |
There was a problem hiding this comment.
Please remove this @sankalp-r
f6ae843 to
206b4c2
Compare
|
Looks like there are some linter issues @sankalp-r. I'll merge once CI is green |
206b4c2 to
859c14c
Compare
Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>
859c14c to
71dcb75
Compare
Fixed linter issue. |
It's a flaky CI job, rerunning |
Signed-off-by: Sankalp Rangare sankalprangare786@gmail.com
What this PR does / why we need it:
This PR adds a new stage in Promtail called
static_labelsto provide custom labels.Which issue(s) this PR fixes:
Fixes #4384
Special notes for your reviewer:
Checklist