Add drone build job for lambda-promtail images. #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
|
@owen-d @JordanRushing ready for a review here. We finally have a working public ECR repo + drone plugin that can build and push to public ECR repos. |
| @@ -73,6 +75,24 @@ local clients_docker(arch, app) = { | |||
| }, | |||
| }; | |||
|
|
|||
| local lambda_promtail_ecr(app) = { | |||
| name: '%s-image' % if $.settings.dry_run then 'build-' + app else 'publish-' + app, | |||
| image: 'cstyan/ecr', | |||
There was a problem hiding this comment.
Should this not be grafana/ecr perhaps?
There was a problem hiding this comment.
Yeah, we can move my fork of the ECR plugin + the docker image to grafana owned repos at any point.
There was a problem hiding this comment.
For context: why isn't it that way already? Just testing for now?
DylanGuedes
reviewed
Oct 22, 2021
Signed-off-by: Callum Styan <callumstyan@gmail.com>
There was a problem hiding this comment.
@cstyan once you've regenerated the .drone.yml this is good to go 👍
.drone/drone.yml
Outdated
| - depends_on: | ||
| - image-tag | ||
| environment: | ||
| DOCKER_LAUNCH_DEBUG: true |
There was a problem hiding this comment.
I think you may need to regenerate this file since this was removed.
dannykopping
approved these changes
Oct 25, 2021
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambda promtail image build and publish via drone.
Signed-off-by: Callum Styan callumstyan@gmail.com