Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make LogQL syntax scope from private to public #4446

Merged
merged 3 commits into from
Oct 19, 2021
Merged

make LogQL syntax scope from private to public #4446

merged 3 commits into from
Oct 19, 2021

Conversation

garrettlish
Copy link
Contributor

@garrettlish garrettlish commented Oct 9, 2021 •
edited
Loading

What this PR does / why we need it:
It is the follow-up for #3991, it makes using LogQL syntax outside possible, it also makes LogRange implements Expr interface.

Which issue(s) this PR fixes:
Make LogQL syntax scope from private to public

Special notes for your reviewer:

Checklist

  • Tests updated

@garrettlish garrettlish requested a review from a team as a code owner October 9, 2021 10:29
@garrettlish garrettlish force-pushed the main branch 2 times, most recently from ca833b2 to c9aa30a Compare October 11, 2021 00:43
@garrettlish
Copy link
Contributor Author

@cyriltovena could you please help take a look this PR? Any thoughts, please advise!

@garrettlish
make LogQL syntax scope from private to public
4a205ed 
The follow-up for grafana#3991, it makes using LogQL syntax outside possible, it also makes LogRange implements Expr interface.
cyriltovena
cyriltovena reviewed Oct 12, 2021
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good what's your usage don't you also need constructor ? If not let's go like this.

@garrettlish
Copy link
Contributor Author

@cyriltovena
I don't make constructor as public is because usually we are using logql.ParseExpr to parse LogQL syntax outside (we don't manually construct the syntax objects).
However, agree with you, making constructor also public should be better, let me make the change.

@garrettlish
Copy link
Contributor Author

@cyriltovena made constructor as public as well via ab9d0a9, could you please help review again? Thanks!

@cyriltovena
Copy link
Contributor

I didn't need ab9d0a9 I was just wondering what you need.

@cyriltovena
Copy link
Contributor

If you don't need it let's keep the change small. Revert and I'll merge it.

@garrettlish
Copy link
Contributor Author

@cyriltovena reverted ab9d0a9 as we discussed

@garrettlish
Copy link
Contributor Author

@cyriltovena do you get chance to take a look this PR, thanks?

cyriltovena
cyriltovena approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit a046d79 into grafana:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garrettlish @cyriltovena