Loki: Bug: frontend waiting on results which would never come #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r query results leading to goroutines waiting forever for results that would never come...
kavirajk
reviewed
Oct 5, 2021
| if resp.err != nil { | ||
| return nil, resp.err | ||
| select { | ||
| case <-ctx.Done(): |
There was a problem hiding this comment.
Q: Should we put some info or error log (recording ctx.Error()) when we know we stop because of ctx.Done()?
Wouldn't it help to understand why we got partial results in those cases?
There was a problem hiding this comment.
Since he now returns the error it's the caller that can log and do whatever he wants with the error.
There was a problem hiding this comment.
@cyriltovena Agree :) I added that comment before the return statement was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not also checking the context to see if it was canceled while waiting for goroutines to return with query results leading to a leak of goroutines.