Minor dashboard fixes #4401
Minor dashboard fixes #4401
Conversation
dropdown to other dashboards. Signed-off-by: Callum Styan <callumstyan@gmail.com>
| @@ -54,16 +53,17 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |||
| }, | |||
| ], | |||
| } + | |||
| g.dashboard('Loki / Chunks') | |||
| $.dashboard('Loki / Chunks') | |||
There was a problem hiding this comment.
I'd suggest staying away from the global $ if you can; it can cause some fun issues with jsonnet and also makes it hard to determine which function it's using.
What was the reason behind this change? AFAICS consistency with other dashboards?
There was a problem hiding this comment.
So that we can use addClusterSelectorTemplates(false) which is defined in the mixin's dashboard-utils.libsonnet, which gives us the link dropdown: https://github.com/grafana/loki/blob/main/production/loki-mixin/dashboards/dashboard-utils.libsonnet#L32-L43
I haven't written any jsonnet in ~1y so if you know a better way/possible refactor I'm all ears!
There was a problem hiding this comment.
Ah, ok. Have a look at line 1:
local utils = import 'mixin-utils/utils.libsonnet';
You can import a file to a local var, and then use that.
However it seems like we're peppering a bunch of files with $ so let me not hold you up on this.
Fix to retention dashboard (seems like query panel without a
panel(...)line to set the name throws an error, plus add links + selector copying dropdown to other dashboards (top right of dashboard, links to other dashboards and copies over cluster selectors, etc.).