CI: Fixing linter deprecations #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2021 08:05
Replacing deprecated golint with revive (golangci/golangci-lint#1965) Removing interfacer (golangci/golangci-lint#1755) Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
golintwith[revive](https://github.com/mgechev/revive#installation)(Deprecate golint golangci/golangci-lint#1965)interfacer(DeprecateInterfacerlinter golangci/golangci-lint#1755)megacheckwithstaticcheck(https://pkg.go.dev/github.com/aspenteam/go-tools/cmd/megacheck)Which issue(s) this PR fixes:
Partially addresses #1002
Special notes for your reviewer:
I did not include the
prealloclinter as suggested by Marco yet as I didn't want to complicate this PR with the requisite changes it would introduce to get CI passing. This should be done in a subsequent PR.I did implement changes to make
revivepass, as it's a little more strict thatgolintand the suggestions it came up with were all reasonable.Checklist