Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluentD output plugin: Remove an unused variable when processing chunks #4261

Merged
merged 1 commit into from
Oct 12, 2021
Merged

FluentD output plugin: Remove an unused variable when processing chunks #4261

merged 1 commit into from
Oct 12, 2021

Conversation

MrWong99
Copy link
Contributor

@MrWong99 MrWong99 commented Sep 2, 2021

I couldn't figure out why this variable is there. If I am missing any global variables (or something similar) feel free to close this PR without any notice.

What this PR does / why we need it:

Removes an unused variable to clean up the code a tiny bit.

I couldn't figure out why this variable is there. If I am missing any global variables by fluentd feel free to close this PR without any notice
@MrWong99 MrWong99 requested a review from a team as a code owner September 2, 2021 13:22
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021

CLA assistant check
All committers have signed the CLA.

@stale
Copy link

stale bot commented Oct 11, 2021

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Oct 11, 2021
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sorry for the delay.

@cyriltovena cyriltovena merged commit 00168b3 into grafana:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants