Parser: Allow literal control chars in logfmt decoder #3932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows logfmt to handle newlines so long as they are quoted as expected. It still unquotes control chars so nothing should ever break. It just throws less errors.
Rant
There are other issues I have ignored. The main one being that the
ScanKeyval
parser tries to be more efficient by avoiding callingunquoteBytes
unless it sees a\
, but it relies onunquoteBytes
to handle utf8. So a unicode token without a\
may not be decoded correctly.unquoteBytes
also has its own logic to check for slashes so it's inefficientunquoteBytes
also seems to expect that the given string starts and ends with"
but surely anything passing the string has already checked for these delimiters so, why pass them?.. another mystery. And also why does it care if it finds an unescaped quote char, if its not a stream scanner?Basically someone should inline some of
unquoteBytes
code intoScanKeyval
, is what I'm getting at.Which issue(s) this PR fixes:
Fixes #3927
Checklist