Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go and Alpine versions #3481

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Update Go and Alpine versions #3481

merged 3 commits into from
Mar 17, 2021

Conversation

slim-bean
Copy link
Collaborator

No description provided.

@cyriltovena cyriltovena mentioned this pull request Mar 15, 2021
Closed
cyriltovena added a commit to cyriltovena/loki that referenced this pull request Mar 15, 2021
@cyriltovena
Set the byte slice cap correctly when unsafely converting string.
e122940 
Fixes grafana#3485

Should also unblock grafana#3481

When unsafely converting string to bytes the cap of the bytes is lost but not when doing bytes to string.
It seems that this is only a problem when using go 1.16 or when using delve.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena mentioned this pull request Mar 15, 2021
Merged
cyriltovena added a commit that referenced this pull request Mar 16, 2021
@cyriltovena
Set the byte slice cap correctly when unsafely converting string. (#3487
d6ecfd2 
)

Fixes #3485

Should also unblock #3481

When unsafely converting string to bytes the cap of the bytes is lost but not when doing bytes to string.
It seems that this is only a problem when using go 1.16 or when using delve.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena force-pushed the update-go-and-alpine branch from e70dee3 to 1ae0647 Compare March 16, 2021 08:15
@cyriltovena
Copy link
Contributor

update your PR with upstream change which should fix the build.

@cyriltovena
gomod
868c9b8 
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
cyriltovena approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 36ec92c into master Mar 17, 2021
@slim-bean slim-bean deleted the update-go-and-alpine branch March 17, 2021 13:15
perrinjerome pushed a commit to perrinjerome/loki that referenced this pull request Jun 10, 2021
@cyriltovena @perrinjerome
Set the byte slice cap correctly when unsafely converting string. (gr…
da6d45f 
…afana#3487)

Fixes grafana#3485

Should also unblock grafana#3481

When unsafely converting string to bytes the cap of the bytes is lost but not when doing bytes to string.
It seems that this is only a problem when using go 1.16 or when using delve.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slim-bean @cyriltovena