Loki: Per Tenant Runtime Configs #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
approved these changes
Mar 10, 2021
| Querier: {Store, Ring, Server, IngesterQuerier}, | ||
| QueryFrontend: {Server, Overrides}, | ||
| Ruler: {Ring, Server, Store, RulerStorage, IngesterQuerier, Overrides}, | ||
| Ingester: {Store, Server, MemberlistKV, TenantConfigs}, |
There was a problem hiding this comment.
Not sure about adding it here, but you're future proofing the modules in case we add to the tenant configs
Codecov Report
@@ Coverage Diff @@
## master #3460 +/- ##
==========================================
- Coverage 63.29% 63.08% -0.22%
==========================================
Files 205 205
Lines 17550 17615 +65
==========================================
+ Hits 11109 11113 +4
- Misses 5445 5505 +60
- Partials 996 997 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A way to change values within Loki at runtime, exactly the way overrides work but we use overrides explicitly for Limits
Rather than overload the Limits struct with non limit things instead I am creating another struct for runtime Config changes.