Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logql/absent label optimization #3299

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Feb 7, 2021

Enables us to avoid extracting labels unnecessarily for the absent_over_time function, which always returns an empty label set.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 5f0c06a into grafana:master Feb 9, 2021
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Feb 15, 2021
* absent_over_time does not extract unnecessary labels

* rebase fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants