-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only applies entry limits to non-SampleExprs. #2850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
requested review from
achatterjee-grafana and
oddlittlebird
as code owners
October 29, 2020 21:10
Codecov Report
@@ Coverage Diff @@
## master #2850 +/- ##
==========================================
- Coverage 61.37% 61.28% -0.10%
==========================================
Files 179 179
Lines 14438 14443 +5
==========================================
- Hits 8862 8851 -11
- Misses 4766 4780 +14
- Partials 810 812 +2
|
@@ -1598,7 +1598,7 @@ logs in Loki. | |||
# CLI flag: -distributor.max-line-size | |||
[max_line_size: <string> | default = none ] | |||
|
|||
# Maximum number of log entries that will be returned for a query. 0 to disable. | |||
# Maximum number of log entries that will be returned for a query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# Maximum number of log entries that will be returned for a query. | |
# Maximum number of log entries that returned for a query. |
cyriltovena
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't think it's related to #2863 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues:
-validation.max-entries-limit
.0
does not mean disabled.