fix flaky tests in boltdb-shipper #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* established pattern Signed-off-by: Joe Elliott <number101010@gmail.com> * First pass http config Signed-off-by: Joe Elliott <number101010@gmail.com> * Added insecure. Include bucketn names Signed-off-by: Joe Elliott <number101010@gmail.com> * Added tests Signed-off-by: Joe Elliott <number101010@gmail.com> * Tests pass! Signed-off-by: Joe Elliott <number101010@gmail.com> * Added url test Signed-off-by: Joe Elliott <number101010@gmail.com> * Added mixed config test Signed-off-by: Joe Elliott <number101010@gmail.com> * added sse support Signed-off-by: Joe Elliott <number101010@gmail.com> * PutUserMetadata Signed-off-by: Joe Elliott <number101010@gmail.com> * Removed comments Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * Better error contextualization Signed-off-by: Joe Elliott <number101010@gmail.com> * Improved error msgs Signed-off-by: Joe Elliott <number101010@gmail.com> * Added yaml tags and descriptions Signed-off-by: Joe Elliott <number101010@gmail.com> * Moved storage client test to where it will work Signed-off-by: Joe Elliott <number101010@gmail.com> * Updated docs and changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * removed putUserMetaData Signed-off-by: Joe Elliott <number101010@gmail.com> * removed capitlization of error msgs Signed-off-by: Joe Elliott <number101010@gmail.com> * errors cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * removed obsolete comment Signed-off-by: Joe Elliott <number101010@gmail.com> * Cleaned up comments Signed-off-by: Joe Elliott <number101010@gmail.com> * Addressed feedback Signed-off-by: Joe Elliott <number101010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some of the tests in
boltdb-shipperwere failing intermittently due to possible reuse of the same directories to build test data.This is a possible fix for it which makes sure temp directories are created with distinct prefixes.