Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service discovery refactor #2761

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Service discovery refactor #2761

merged 4 commits into from
Oct 15, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Oct 14, 2020

Mimics how Prometheus used to reference scrape configs & adds more tests.

@codecov-io
Copy link

Codecov Report

Merging #2761 into master will decrease coverage by 0.16%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2761      +/-   ##
==========================================
- Coverage   61.68%   61.51%   -0.17%     
==========================================
  Files         171      172       +1     
  Lines       13389    13395       +6     
==========================================
- Hits         8259     8240      -19     
- Misses       4378     4402      +24     
- Partials      752      753       +1     
Impacted Files Coverage Δ
pkg/promtail/scrapeconfig/scrapeconfig.go 37.50% <0.00%> (ø)
pkg/promtail/targets/file/filetargetmanager.go 0.00% <0.00%> (ø)
pkg/promtail/targets/stdin/stdin_target_manager.go 71.69% <100.00%> (-0.53%) ⬇️
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/promtail/targets/file/tailer.go 70.09% <0.00%> (-5.61%) ⬇️
pkg/promtail/targets/file/filetarget.go 64.08% <0.00%> (-2.12%) ⬇️
pkg/promtail/config/config.go 0.00% <0.00%> (ø)
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 607ccc4 into grafana:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants