helm chart: Fix broken logo #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log has moved, so Chart.yaml logo is incorrect. This causes tools like CNCF Artifact Hub to fail displaying the logo.
|
|
Codecov Report
@@ Coverage Diff @@
## master #2651 +/- ##
==========================================
- Coverage 61.22% 61.18% -0.05%
==========================================
Files 172 172
Lines 13360 13360
==========================================
- Hits 8180 8174 -6
- Misses 4431 4438 +7
+ Partials 749 748 -1
|
|
Thanks @scottrigby! Could you also bump the loki-stack chart patch version too? |
|
@slim-bean sure, do you want that as a separate PR? |
|
same PR, thanks! |
cyriltovena
reviewed
Sep 29, 2020
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
approved these changes
Nov 4, 2020
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
* Fix broken logo The log has moved, so Chart.yaml logo is incorrect. This causes tools like CNCF Artifact Hub to fail displaying the logo. * Update all logos. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The log has moved, so Chart.yaml logo is incorrect. This causes tools like CNCF Artifact Hub to fail displaying the logo.
Which issue(s) this PR fixes:
Fixes #Special notes for your reviewer:
Similar to #2385
Checklist
- [ ] Documentation added- [ ] Tests updated