-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usage of sync/atomic with uber-go/atomic #2449
Conversation
Signed-off-by: Javier Palomo <javier.palomo.almena@gmail.com>
Signed-off-by: Javier Palomo <javier.palomo.almena@gmail.com>
Signed-off-by: Javier Palomo <javier.palomo.almena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2449 +/- ##
==========================================
- Coverage 62.91% 62.77% -0.14%
==========================================
Files 162 162
Lines 13952 13952
==========================================
- Hits 8778 8759 -19
- Misses 4491 4510 +19
Partials 683 683
|
Hey, thanks for this -- it looks great. I agree using Feel free to installl it here: https://github.com/grafana/loki/blob/master/loki-build-image/Dockerfile#L10-L12 and then reference in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR!
Regarding faillint
, you are right about using loki-build-image/Dockerfile
for setting up additional tools.
You can check PR in Cortex for reference. cortexproject/cortex#2272
Signed-off-by: Javier Palomo <javier.palomo.almena@gmail.com>
Signed-off-by: Javier Palomo <javier.palomo.almena@gmail.com>
Thanks for the pointers @owen-d @sandeepsukhani. It was not possible to add it to the I am not that familiar with the structure of this particular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
What this PR does / why we need it: Replaces all direct usages of
sync/atomic
withgo.uber.org/atomic
. That way we ensure that all access to variables that have atomic access is in fact always atomic.Which issue(s) this PR fixes:
Partially addresses #2448
Special notes for your reviewer: This only updates the code to use the alternative package. I haven't added any automation/linter to make sure that this is enforced.
For that, we could use faillint, but I am not 100% sure of where this project is handling the installation of additional tools. Is that on
loki-build-image/Dockerfile
?Checklist