Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: clarified globbing behaviour of __path__ of the doublestar library #2437

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

wardbekker
Copy link
Member

clarified globbing behaviour of path of the doublestar library

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@codecov-commenter
Copy link

Codecov Report

Merging #2437 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2437      +/-   ##
==========================================
+ Coverage   62.70%   62.74%   +0.03%     
==========================================
  Files         162      162              
  Lines       13850    13850              
==========================================
+ Hits         8685     8690       +5     
+ Misses       4488     4486       -2     
+ Partials      677      674       -3     
Impacted Files Coverage Δ
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/promtail/targets/file/filetarget.go 69.64% <0.00%> (+1.78%) ⬆️
pkg/promtail/targets/file/tailer.go 78.40% <0.00%> (+4.54%) ⬆️

@wardbekker wardbekker requested review from owen-d and slim-bean July 28, 2020 15:43
Co-authored-by: Ed Welch <edward.welch@grafana.com>
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@owen-d owen-d merged commit 3f7bc33 into master Jul 28, 2020
@owen-d owen-d deleted the wardbekker-patch-1 branch July 28, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants