-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Propose new governance #2137
Conversation
Signed-off-by: Richard Hartmann <richih@richih.org>
Codecov Report
@@ Coverage Diff @@
## master #2137 +/- ##
==========================================
+ Coverage 62.02% 62.06% +0.03%
==========================================
Files 156 156
Lines 12531 12531
==========================================
+ Hits 7772 7777 +5
+ Misses 4149 4145 -4
+ Partials 610 609 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I guess we need more than just me aggreeing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Richard Hartmann <richih@richih.org>
Signed-off-by: Richard Hartmann <richih@richih.org>
docs/community/governance.md
Outdated
If the new member proposal is accepted, the proposed team member should be contacted privately via email to confirm or deny their acceptance of team membership. This email will also be CC'd to loki-team@googlegroups.com for record-keeping purposes. | ||
The current team members are: | ||
|
||
- Aditya C S - [adityacs](https://github.com/adityacs) ([Grafana Labs](https://grafana.com/)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adityacs You're at IBM I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; @sh0rez also pointed this out and also thinks IBM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the governance requires to add the company name, I am OK to get my name removed here. Later I will create a PR to add my name if I get an official approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, was not aware. I can remove the name, or put you as independent, whichever you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichiH You don't have to be sorry 😄 . Independent should be fine.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit then LGTM
[announce]: https://groups.google.com/forum/#!forum/loki-announce | ||
[coc]: https://github.com/grafana/loki/blob/master/CODE_OF_CONDUCT.md | ||
[devs]: https://groups.google.com/forum/#!forum/loki-developers | ||
[maintainers]: https://github.com/grafana/loki/blob/master/MAINTAINERS.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't exist I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, @slim-bean needs to decide if that's any subsystem maintainers or if he wants to be listed for *
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To start we won't assign any subsystem maintainers, however I expect this to change over time.
I think you are stuck with me for all the things :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ALL THE THINGS!!!111
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Richard Hartmann <richih@richih.org>
8 out of 11 people agree, as such supermajority has been reached. |
GitHub is wonky, sorry @sh0rez you will need to LGTM it. |
This is not yet ready to merge. It serves as a basis for discussion and needs to be voted upon if it were to be accepted & merged.