Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluentd plugin: support placeholders in tenant field #2074

Merged
merged 1 commit into from
May 14, 2020

Conversation

osela
Copy link
Contributor

@osela osela commented May 14, 2020

What this PR does / why we need it:

When running in a multi-tenant environment with a single fluentd and loki in multi-tenant mode, it's currently impossible to use a single loki output match because the tenant field is static. You basically need to have a separate match for every tenant and handle the routing yourself.

This PR adds placeholder support to the tenant field, so each chunk can be sent to the right tenant based on tag or record values while still using a single loki output match.

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented May 14, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge it soon !
Thanks a ton !

@slim-bean slim-bean merged commit 835dd29 into grafana:master May 14, 2020
@osela
Copy link
Contributor Author

osela commented May 15, 2020

@cyriltovena would you mind pushing the new version to rubygems.org?

@cyriltovena
Copy link
Contributor

Will do

cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
* switching azblob fetching to lower level function to avoid unnecessary parallel requests

Signed-off-by: Ken Haines <khaines@microsoft.com>

* updating CHANGELOG.md

Signed-off-by: Ken Haines <khaines@microsoft.com>

* PR Feedback

Signed-off-by: Ken Haines <khaines@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants