-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearer error response from push endpoint when labels are malformed #1750
Conversation
I signed the agreement, made sure my emails are added to my account as well. Not sure why it says I haven't signed it 🤔 |
Hi @talham7391 thanks for the PR! It looks like the email associated with the commit is not valid and therefore github can't link it to your account. You would need to |
efaf71a
to
7e33912
Compare
Thanks! @slim-bean |
Codecov Report
@@ Coverage Diff @@
## master #1750 +/- ##
==========================================
- Coverage 64.33% 64.28% -0.05%
==========================================
Files 121 121
Lines 9081 9081
==========================================
- Hits 5842 5838 -4
- Misses 2835 2837 +2
- Partials 404 406 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a small suggestion if you have time.
What this PR does / why we need it:
Currently, when users use the
/loki/api/v1/push
with a malformedlabels
, they get an error response saying something along the lines of:parse error at line 1, col 4: literal not terminated
.It isn't clear that the
labels
are the issue. This PR makes it clear.Which issue(s) this PR fixes:
Fixes #1727
Checklist