-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add headers for WebSocket #1689
Add headers for WebSocket #1689
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1689 +/- ##
==========================================
- Coverage 62.09% 61.98% -0.11%
==========================================
Files 111 111
Lines 8391 8391
==========================================
- Hits 5210 5201 -9
- Misses 2788 2793 +5
- Partials 393 397 +4
|
@shokada Thanks for the contribution, we don't use this gateway ourselves, we have our own. Have you tested this in your cluster ? |
@cyriltovena Yes, I tested this in my cluster. It seems to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After our discussion, LGTM pending removal of the OrgID headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good! I will take a final look in the next day or so but we should be able to get this merged, thanks @shokada
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When Loki Canary connects to a gateway, the following error occurred.
Loki Canary opens a WebSocket connection to Loki, so the gateway needs to send a request including the
Upgrade
andConnection
headers.http://nginx.org/en/docs/http/websocket.html
And, since
/loki/api/v1/tail
and/api/prom/tail
are handled inQuerier
module instead ofQueryFrontend
module, the gateway needs to send a request toQuerier
.