Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): do not disable CGO in Makefile #16271

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix(ci): do not disable CGO in Makefile #16271

merged 1 commit into from
Feb 14, 2025

Conversation

ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Feb 14, 2025

What this PR does / why we need it:

Cleans up unused vars. Also fixes an issue that is preventing promtail builds from running with CGO_ENABLED

Which issue(s) this PR fixes:
Fixes #16220

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli requested a review from a team as a code owner February 14, 2025 07:56
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also backport to release-3.4.x

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Feb 14, 2025

This PR must be merged before a backport PR will be created.

@ashwanthgoli ashwanthgoli enabled auto-merge (squash) February 14, 2025 08:02
@ashwanthgoli ashwanthgoli merged commit 810dff9 into main Feb 14, 2025
61 checks passed
@ashwanthgoli ashwanthgoli deleted the fix-CGO-makefile branch February 14, 2025 08:03
loki-gh-app bot pushed a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for reading the systemd journal is not compiled into this build of promtail
2 participants