Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ksonnet)!: clean-up deprecated configs #16007

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Conversation

ashwanthgoli
Copy link
Contributor

What this PR does / why we need it:

  • Remove deprecated storage backend configs (cassandra, dynamo, bigtable)
  • Removes table manager config and workload
  • storage_backend config is now simplified to accept a single backend type
  • Use tsdb and schema v13 by default

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli requested a review from a team as a code owner January 30, 2025 04:57
Copy link
Collaborator

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Quick question what is the case for Azure in storage_backend?

@ashwanthgoli
Copy link
Contributor Author

@periklis added one for azure

@ashwanthgoli ashwanthgoli merged commit 76183fa into main Jan 31, 2025
60 checks passed
@ashwanthgoli ashwanthgoli deleted the ksonnet-loki-cleanup branch January 31, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants