-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Map streams to scopes and add per-scope ingestion block. #15561
Closed
Closed
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
3196552
Add per-scope ingestion block.
DylanGuedes 4ee1420
Emit error message
DylanGuedes cda0b3a
Block at entry/stream iteration level.
DylanGuedes aa1ac74
fix lnit
DylanGuedes 059df30
Update docs
DylanGuedes f5522f8
lint
DylanGuedes 825d7af
Use empty map instead of nil
DylanGuedes 0462fb0
lint import
DylanGuedes f5559b8
Add support for enforced labels.
DylanGuedes 67ded00
Fix tests
DylanGuedes e174ed3
Merge branch 'main' of github.com:grafana/loki into add-per-scope-limits
DylanGuedes 9b17ed7
Remove merge marks
DylanGuedes d03772d
Remove more conflict marks
DylanGuedes d080a8f
Reuse lbs.
DylanGuedes 16f3937
Test multiple scopes
DylanGuedes 37a1249
Improve flag docs
DylanGuedes 4796661
Update docs
DylanGuedes 65c6834
Rename `scope` to `policy`.
DylanGuedes 885aa4f
Better docs
DylanGuedes 503088a
Add new configs to limits test.
DylanGuedes eed8acd
fix lint
DylanGuedes 9b26693
Update tests
DylanGuedes bd04998
Make per-retention period metric
DylanGuedes 74ddaea
Fix compilation errors
DylanGuedes 2a9f4dc
fix lint
DylanGuedes 98bf0b7
Fix lint
DylanGuedes 8e1922e
Use both variables
DylanGuedes d9e0007
Use new retention on those metrics invocation
DylanGuedes 7060090
Emit metrics everywhere
DylanGuedes 31e0439
Use retention when blocked policy
DylanGuedes b35d95e
Pass the retention limits to the ingester
DylanGuedes 0cfb7cf
Use retention on ingester metrics
DylanGuedes f1ae37f
Fix test
DylanGuedes 2a597c4
Fix test
DylanGuedes efd7207
last one?
DylanGuedes bf47258
Improve docs
DylanGuedes 0b15b81
refactor to reuse code
DylanGuedes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there defaults for any of these settings? (even if the default is nothing is set?)
Also, these settings could definitely use an example in the description, since users might not know what these mappings should look like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I should have closed this PR earlier. I'm dropping it to work on smaller PRs (I already merged one of them). Regarding your suggestion: absolutely. I'll tackle that on my next PRs.