Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade apiVersion of deployment/daemonset for k8s v1.16+ #1523

Closed
wants to merge 4 commits into from
Closed

Upgrade apiVersion of deployment/daemonset for k8s v1.16+ #1523

wants to merge 4 commits into from

Conversation

benjaminhuo
Copy link

@benjaminhuo benjaminhuo commented Jan 15, 2020

What this PR does / why we need it:
Upgrade apigroup and apiversion of promtail daemonset for k8s v1.16+

Which issue(s) this PR fixes:
Got below error when deploying loki on k8s 1.16

tk apply environments/loki
error: unable to recognize "STDIN": no matches for kind "DaemonSet" in version "extensions/v1beta1"
Warning: There are no differences. Your apply may not do anything at all.
Applying to namespace 'loki' of cluster 'cluster.local' at 'https://lb.kubesphere.local:6443' using context 'kubernetes-admin@cluster.local'.
Please type 'yes' to confirm: no
aborted by user

tk apply environments/loki/
error: unable to recognize "STDIN": no matches for kind "Deployment" in version "apps/v1beta1"
Warning: There are no differences. Your apply may not do anything at all.
Applying to namespace 'loki' of cluster 'cluster.local' at 'https://lb.kubesphere.local:6443' using context 'kubernetes-admin@cluster.local'.
Please type 'yes' to confirm: no
aborted by user

@benjaminhuo benjaminhuo changed the title Upgrade apiVersion of promtail daemonset for k8s v1.16+ [WIP] Upgrade apiVersion of deployment/daemonset/statefulset for k8s v1.16+ Jan 15, 2020
Signed-off-by: Benjamin <benjamin@yunify.com>
@benjaminhuo benjaminhuo changed the title [WIP] Upgrade apiVersion of deployment/daemonset/statefulset for k8s v1.16+ Upgrade apiVersion of deployment/daemonset for k8s v1.16+ Jan 15, 2020
@sh0rez
Copy link
Member

sh0rez commented Jan 17, 2020

Hi, this should be covered by #1543. This is a similar (identical PR?) I just created as a hotfix and merged. In case we could have used this one instead, my apologies!

@sh0rez sh0rez closed this Jan 17, 2020
@benjaminhuo
Copy link
Author

benjaminhuo commented Jan 18, 2020

Yeah, it's covered by 1543
Thanks for the notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants