Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k211] chore: Use filesystem backed writer for blooms #13559

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 7aa7c15 from #13522


What this PR does / why we need it:

The DirectoryBlockWriter and DirectoryBlockReader are used to avoid OOMing of compactors/builders.

The tradeoff is that the writer/reader needs to be cleaned up and that it is I/O bound.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

The DirectoryBlockWriter and DirectoryBlockReader are used to avoid OOMing of compactors/builders.

The tradeoff is that the writer/reader needs to be cleaned up and that it is I/O bound.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
(cherry picked from commit 7aa7c15)
@grafanabot grafanabot requested a review from a team as a code owner July 17, 2024 14:09
@grafanabot grafanabot added backport size/L type/bug Somehing is not working as expected labels Jul 17, 2024
@grafanabot grafanabot requested a review from chaudum July 17, 2024 14:09
@salvacorts salvacorts merged commit 1eb3c09 into k211 Jul 17, 2024
63 checks passed
@salvacorts salvacorts deleted the backport-13522-to-k211 branch July 17, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/L type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants