Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blooms): Better task naming #13361

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:
Before this PR, tasks names were UUIDs, this PR changes this so tasks are names after the table, tenant, TSDB checksum, FP range and number of gaps.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts changed the title Better task naming refactor(blooms): Better task naming Jul 1, 2024
@salvacorts salvacorts marked this pull request as ready for review July 1, 2024 09:45
@salvacorts salvacorts requested a review from a team as a code owner July 1, 2024 09:45
return &Task{
ID: uuid.NewString(),
ID: fmt.Sprintf("%s-%s-%s-%d-%d", table.Addr(), tenant, bounds.String(), tsdb.Checksum, len(gaps)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do tasks need an ID at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it useful to track its progress throughout the planner and builder.

@salvacorts salvacorts merged commit 0602b90 into main Jul 1, 2024
61 checks passed
@salvacorts salvacorts deleted the salvacorts/bloom-refactor/task-naming branch July 1, 2024 15:10
@chaudum chaudum mentioned this pull request Aug 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants