refactor(blooms): Builder retrieves tasks from planner #13046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
approved these changes
May 29, 2024
| // will be canceled and the loop will exit. | ||
| protoTask, err := c.Recv() | ||
| if err != nil { | ||
| if errors.Is(c.Context().Err(), context.Canceled) { |
There was a problem hiding this comment.
I think you should check err for context.Canceled, or, check if c.Context() == nil before c.Recv()
There was a problem hiding this comment.
If the connection context is canceled, c.Recv() will return right after calling it.
(I actually had it as you suggest but noticed the behaviour while testing and decided to remove it for simplicity)
pkg/bloombuild/builder/metrics.go
Outdated
| Subsystem: metricsSubsystem, | ||
| Name: "task_time_seconds", | ||
| Help: "Time spent processing a task.", | ||
| Buckets: prometheus.DefBuckets, |
There was a problem hiding this comment.
The default bucket range might be too small.
pkg/bloombuild/builder/metrics.go
Outdated
| Name: "task_completed_total", | ||
| Help: "Total number of task completed", | ||
| }, []string{"status"}), | ||
| taskTime: promauto.With(r).NewHistogramVec(prometheus.HistogramOpts{ |
There was a problem hiding this comment.
nit: would name it taskDuration
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the logic to the bloom builder to connect and receive tasks from the bloom planner. Tasks are not processed yet, only received.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR