fluent-bit: edge case tests #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Does that actually work the way I have setup the config for you ? I remember you took a slightly different approach ? |
2 tasks
I was just replying in the merged PR. "Compatible" is to be defined -- it fits our use case (and actually I prefer your solution with separate configuration for relabeling and dropping labels to the unified approach I had: configuration is easier to read and code seems more simple). Thank you for the good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds some edge case tests to the fluent-bit Loki shipping plugin I added in my draft of the nested JSON relabeling code. All of them run successfully without any code fixes, but they somewhat define the expected behavior for non-string contents. fluent-bit can parse JSON and put it into labels, so one must expect arbitrary JSON (and thus nested maps) with integers, arrays and so on.
If the current behavior (like list
{42, 43}passed as[42 43]to Loki) are not desired, what should they look like? Does Loki support numeric labels? Currently, the plugin just converts them to strings.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist