Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different packaging for release binaries #1113

Closed
aledegano opened this issue Oct 3, 2019 · 3 comments · Fixed by #1160
Closed

Different packaging for release binaries #1113

aledegano opened this issue Oct 3, 2019 · 3 comments · Fixed by #1160
Labels
component/packaging help wanted We would love help on these issues. Please come help us! type/enhancement Something existing could be improved

Comments

@aledegano
Copy link

We deploy promtail on all our infra VMs as native binaries. Unfortunately the choice of gunzipping the binary file is a bit incovenient for us for two reasons:

  1. We deploy with Saltstack that natively (through archive.extract) is unable to open .gz files (it can open .tar.gz though)
  2. On Windows there's no native tool that can uncompress the .gz file and thus would require to install gzip first (or similar archive manager)

A simple solution could be to compress the resulting binary in .zip format which is much more supported.

Alternatively the uncompressed binary would work too.

How does the community feel about this?
Thanks!

@sh0rez sh0rez added component/packaging type/enhancement Something existing could be improved labels Oct 8, 2019
@sh0rez
Copy link
Member

sh0rez commented Oct 8, 2019

Hi, thanks for pointing out! I assumed that gzip was well-supported at the time choosing this format.

Of course we can switch to a more common format. I wonder what fits best here, tar.gz is probably the most common format in the UNIX world, while zip should be supported literally everywhere.

We would need to carefully update install instructions to make users aware of this change / update all old releases

What do you think @slim-bean @rfratto @cyriltovena

@cyriltovena
Copy link
Contributor

yes let's do it !

@cyriltovena cyriltovena added hacktoberfest help wanted We would love help on these issues. Please come help us! labels Oct 9, 2019
@stale
Copy link

stale bot commented Nov 8, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Nov 8, 2019
@sh0rez sh0rez removed the stale A stale issue or PR that will automatically be closed. label Nov 8, 2019
cyriltovena pushed a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
…acing

 Update grpc-opentracing to latest version at new home
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/packaging help wanted We would love help on these issues. Please come help us! type/enhancement Something existing could be improved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants