Skip to content

Commit

Permalink
Allows to change the log driver mode and buffer size. (#2116)
Browse files Browse the repository at this point in the history
Before those configs where not allowed, but docker can use them to have a different log delivery behaviour.

see https://docs.docker.com/config/containers/logging/configure/#configure-the-delivery-mode-of-log-messages-from-container-to-log-driver

Potentially fixes #2017

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
  • Loading branch information
cyriltovena authored Jun 4, 2020
1 parent b95db8d commit bedab49
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cmd/docker-driver/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ func validateDriverOpt(loggerInfo logger.Info) error {
case "env-regex":
case "max-size":
case "max-file":
case "mode":
case "max-buffer-size":
default:
return fmt.Errorf("%s: wrong log-opt: '%s' - %s", driverName, opt, loggerInfo.ContainerID)
}
Expand Down

0 comments on commit bedab49

Please sign in to comment.