Skip ingester tailer filtering if no filter is set

grafana · Sep 30, 2019 · 42040f2 · 42040f2
1 parent 3e0621e
commit 42040f2
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pkg/ingester/tailer.go b/pkg/ingester/tailer.go
@@ -128,9 +128,14 @@ func (t *tailer) send(stream logproto.Stream) {
 }
 
 func (t *tailer) filterEntriesInStream(stream *logproto.Stream) {
+	// Optimization: skip filtering entirely, if no filter is set
+	if t.filter == nil {
+		return
+	}
+
 	var filteredEntries []logproto.Entry
 	for _, e := range stream.Entries {
-		if t.filter == nil || t.filter([]byte(e.Line)) {
+		if t.filter([]byte(e.Line)) {
 			filteredEntries = append(filteredEntries, e)
 		}
 	}