Skip to content

Commit

Permalink
Remove nosiy "inflight" requests log entries (#6074)
Browse files Browse the repository at this point in the history
We have enough metrics now (queue time, queue length and metrics.go statistics)
that makes these log entries obselete.

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
  • Loading branch information
kavirajk authored May 4, 2022
1 parent 2264b73 commit 0a4bfbe
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions pkg/querier/worker/scheduler_processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import (
"google.golang.org/grpc"
"google.golang.org/grpc/health/grpc_health_v1"

"github.com/grafana/dskit/tenant"

"github.com/grafana/loki/pkg/lokifrontend/frontend/v2/frontendv2pb"
querier_stats "github.com/grafana/loki/pkg/querier/stats"
"github.com/grafana/loki/pkg/scheduler/schedulerpb"
Expand Down Expand Up @@ -129,15 +127,11 @@ func (sp *schedulerProcessor) querierLoop(c schedulerpb.SchedulerForQuerier_Quer
logger = util_log.WithContext(ctx, sp.log)
)

start := time.Now()
tenant, _ := tenant.TenantID(ctx)
sp.metrics.inflightRequests.Inc()
level.Debug(logger).Log("msg", "tracking inflight request", "tenant", tenant, "op", "enqueue")

sp.runRequest(ctx, logger, request.QueryID, request.FrontendAddress, request.StatsEnabled, request.HttpRequest)

sp.metrics.inflightRequests.Dec()
level.Debug(logger).Log("msg", "tracking inflight request", "tenant", tenant, "op", "dequeue", "duration", time.Since(start))

// Report back to scheduler that processing of the query has finished.
if err := c.Send(&schedulerpb.QuerierToScheduler{}); err != nil {
Expand Down

0 comments on commit 0a4bfbe

Please sign in to comment.