-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adressing linter issues in netext
, netext/httpext
packages
#3484
Conversation
netext
, netext/httpext
packages
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3484 +/- ##
==========================================
+ Coverage 73.16% 73.18% +0.01%
==========================================
Files 267 267
Lines 20076 20076
==========================================
+ Hits 14689 14692 +3
+ Misses 4471 4470 -1
+ Partials 916 914 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but instead of sparkling nolint:revive
it is just better to replace the unused arguments name with _
58f6d2c
to
4970d55
Compare
What?
This PR addresses the linter issues in the
netext
package.It's better to do a review by commits. I've tried to combine them for the impact.
The first commit is applying simple changes.
Everything else deserves a more focused look since it also contains some refactorings.
Note: one linter issue is still there:
Since the function it deserves a separate PR, it's more complicated.
k6/lib/netext/httpext/request.go
Lines 109 to 114 in 856a767
Also,
grpcext
package's linter issues have yet to be touched since I'm planning to address them in #3152Why?
As we agreed, we have to fix the linter issues presented in the
master
branch.Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
Part of #769