Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Fix range error in queries #39

Merged
merged 3 commits into from
Jul 7, 2019
Merged

Fix range error in queries #39

merged 3 commits into from
Jul 7, 2019

Conversation

davkal
Copy link
Collaborator

@davkal davkal commented Jun 14, 2019

Query expansion puts the range statement at the end, which trips up
Flux. This change puts it at the beginning of the expression.

Here is the original error:

,error,reference
,"error in building plan while starting program: cannot submit unbounded read to ""telegraf""; try bounding 'from' with a call to 'range'",

Test this by using telegraf..cpu..usage_system as a query and accept
the expanding suggestion.

davkal added 3 commits June 14, 2019 13:56
Query expansion puts the range statement at the end, which trips up
Flux. This change puts it at the beginning of the expression.

Here is the original error:
```
,error,reference
,"error in building plan while starting program: cannot submit unbounded read to ""telegraf""; try bounding 'from' with a call to 'range'",
```

Test this by using `telegraf..cpu..usage_system` as a query and accept
the expanding suggestion.
@davkal
Copy link
Collaborator Author

davkal commented Jun 14, 2019

Fixes #32

@davkal davkal requested a review from briangann June 18, 2019 12:40
@davkal
Copy link
Collaborator Author

davkal commented Jun 20, 2019

Bump @briangann

@daniellee daniellee self-requested a review July 7, 2019 09:49
Copy link
Contributor

@daniellee daniellee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but it is easy to break. Try pasting in telegraf..cpu..usage_system instead of typing it and then expanding. But that is nothing to do with this change so LGTM.

@daniellee daniellee merged commit 01c6d91 into master Jul 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants