re-add loki 2.4.1 to index.yaml #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Welch <edward.welch@grafana.com>
torstenwalter
pushed a commit
to torstenwalter/chart-releaser
that referenced
this pull request
Nov 10, 2021
So far the index.yaml was loaded directly from the chart repository. In case of GitHub pages that's https://<user or org>.github.io/<repo> The problem with this approach is that GitHub pages use a Content Delivery Network. So the index.yaml files fetched from there might be outdated as there is a delay between a git push to the gh-pages branch until the content is visible. This delay might lead to the situation that one downloads an old index file from and updated that one instead of the most recent index.yaml. For the grafana repository that resulted in already released charts being removed again. - grafana/helm-charts#783 - grafana/helm-charts#796 This PR resolves that issue by reading the index.yaml from the gh_pages branch of the repository. The branch needs to be up-to-date anyhow if you want to create a PR or directly push the changes. It should also be fine for the chart-releaser-action as it uses a fetch-depth: 0 to clone the whole repository. ``` jobs: release: runs-on: ubuntu-latest steps: - name: Checkout uses: actions/checkout@v2 with: fetch-depth: 0 ``` Fixes: helm#143 Signed-off-by: Torsten Walter <torsten.walter@syncier.com>
scottrigby
pushed a commit
to helm/chart-releaser
that referenced
this pull request
Nov 15, 2021
…it repository (#144) * read index.yaml from git repository So far the index.yaml was loaded directly from the chart repository. In case of GitHub pages that's https://<user or org>.github.io/<repo> The problem with this approach is that GitHub pages use a Content Delivery Network. So the index.yaml files fetched from there might be outdated as there is a delay between a git push to the gh-pages branch until the content is visible. This delay might lead to the situation that one downloads an old index file from and updated that one instead of the most recent index.yaml. For the grafana repository that resulted in already released charts being removed again. - grafana/helm-charts#783 - grafana/helm-charts#796 This PR resolves that issue by reading the index.yaml from the gh_pages branch of the repository. The branch needs to be up-to-date anyhow if you want to create a PR or directly push the changes. It should also be fine for the chart-releaser-action as it uses a fetch-depth: 0 to clone the whole repository. ``` jobs: release: runs-on: ubuntu-latest steps: - name: Checkout uses: actions/checkout@v2 with: fetch-depth: 0 ``` Fixes: #143 Signed-off-by: Torsten Walter <torsten.walter@syncier.com> * fix error handling Signed-off-by: Torsten Walter <torsten.walter@syncier.com> * re-add charts-repo flag to avoid breaking changes - message is printed when using the flag to let users know that it's deprecated - update all docs in README Signed-off-by: Torsten Walter <torsten.walter@syncier.com> * Update cr/cmd/index.go Co-authored-by: Reinhard Nägele <unguiculus@gmail.com> Signed-off-by: Torsten Walter <mail@torstenwalter.de> * fix import ordering Signed-off-by: Torsten Walter <torsten.walter@syncier.com> Co-authored-by: Reinhard Nägele <unguiculus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.