Add loki charts #39
Add loki charts #39
Conversation
* Add loki helm chart Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io> * Add promtail helm chart Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io> * Update loki conf from comment Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io> * Update promtail conf from comment Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io> * Update values from comment Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io> * adding resources limit and request Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io> * update README Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io> * rename to daemonset promtail Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io> * use masger for loki Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io> * Move into production repo, re-add readme. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com> * Move to production folder Signed-off-by: Julien Garcia Gonzalez <julien@giantswarm.io> * Review feedback; add instructions for installing Grafana with helm. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
Signed-off-by: Xiang Dai <764524258@qq.com>
* allow promtail target path to be a glob match Promtail now expects __path__ to be a glob. All files that match the glob expression will be tailed. If new files are created that match the glob, they will immediately be tailed. * remove entry from positions file when file is deleted * fix syncing the current positions to positions file * handle file renames When a file is renamed a "rename" and a "create" event are sent. We need to treat the rename as a remove. If the new filename matches the path glob, then we will start tailing it when the "create" event is reveived. * lint
fixes grafana#190 Pods can have multiple containers. This fix ensures that we collect logs for all containers.
add container_name label to logs
…me/ for the helm chart too. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
* Update cortex to include optionally-enforce-metric-name Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com> * Configure validation to allow 'metrics' without metric names. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
* Flush idle chunks properly Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Review feedback Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Review feedback. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com> * Check the correct chunk is full before appending a new chunk. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com> * Add the config to helm and ksonnet too. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
kubelet creates a new log file when a container is restarted. So we need to catpure all log files in the `/var/logs/pods/<uid>/<container_name>/` dir.
tail all container log files
dont add pods twice if they have app and name labels
* update helm values yaml - set persistence.enabled as 'false' as default since there is no pv as default - set persistence.storageClassName as 'default' since even if pv exists, pvc still need storageClassName: ``` Normal FailedBinding 8s (x4 over 35s) persistentvolume-controller no persistent volumes available for this claim and no storage class is set ``` Signed-off-by: Xiang Dai <764524258@qq.com> * helm: delete duplicate empty blank Signed-off-by: Xiang Dai <764524258@qq.com>
Loki pod needs secret mounting privileges
- Loki and promtail are under heavy development, always pulling makes sure bug fixes are shipped
Change image pull default policy to Always
…adiness proble for loki and example antiaffinity.
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Steven Sheehy <ssheehy@firescope.com>
Signed-off-by: Steven Sheehy <ssheehy@firescope.com>
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
|
Thanks for the writeup; this looks great. I think it's reasonable to have a followup PR to change the repository references as you've suggested @torstenwalter. This also seems sensible for @scottrigby's logstash comments. Anything else y'all see that needs to be done? I'd like to merge this soon and start updates on the loki side referencing it :) |
|
@owen-d Whom from Grafana side would need to approve the PR? |
|
Note that charts in the Loki charts repo are signed. This needs to be taken care of here as well. |
Do you know how to do it with chart releaser GitHub action? |
|
I just checked. It currently can't be done with the GitHub action. chart-releaser itself supports signed charts for index and release creation. Meanwhile, chart-releaser also has support for packaging (without signing). But that's not used by the action yet. So, there's a few things left to do. I'll try and look into it. |
|
Support for GPG singing in chart-releaser is on its way now: helm/chart-releaser#81 |
f454cca to
deae822
Compare
| {{ template "loki.fullname" . }}-alerting-rules.yaml: |- | ||
| groups: | ||
| {{- toYaml .Values.alerting_groups | nindent 6 }} | ||
| {{- end }} |
There was a problem hiding this comment.
maybe extra empty line here.
|
I needed to do a force push to be able to include latest commits from loki repository. Will try to fix the build issues in the next days. |
deae822 to
f454cca
Compare
|
@scottrigby @torstenwalter @unguiculus Thank you for all the hard work and the patience ! |
|
We should talk about how to finish this during our next community call on thursday, you're all welcome see https://docs.google.com/document/d/1MNjiHQxwFukm2J4NJRWyRgRIiK7VpokYyATzJ5ce-O8/edit |
|
Should we also copy previous releases to this repo? |
I am sorry I can't join this week due to work related stuff. |
|
@cyriltovena I'm planning to join. |
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
This adds the charts from the loki repository (fluent-bit, loki, loki-stack and promtail) to this repo.
It includes the existing history. You can verify it yourself by checking the history for individual files as in the example:
These are the command, which have been used to migrate the history:
Filtering the history was did a great trick on reducing the history size.
In addition to migrating the repositories the following things have been done:
The goal of this is to publish a newer version of the charts from this repo. I choose to increase the minor version so that it's possible to increase the patch version to deprecate the existing charts and point to the new location.
Note:
grafana,prometheusandlogstashdependencies ofloki-stackstill point to https://kubernetes-charts.storage.googleapis.com/This should be fixed after this is merged.
Here one should decide if one explicitly want's to name all maintainers or refer to a github team which exists.
Not sure if GitHub teams could be resolved, but we could at least use it in CODEOWNERS file.
Part-of: grafana/loki#2593