-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grafana] feat: adds multi-org support to sidecar dashboards #2939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converts `sidecar.dashboards.provider` to a list at `sidecar.dashboards.providers` allowing the definition of multiple providers that can be mappped to orgs as required. still supports the singular variant to retain backwards compatibility and will prepend it to any configured `providers` Signed-off-by: Matt Cockayne <matthew.cockayne@mangopay.com>
…ore concise values Signed-off-by: Matt Cockayne <matthew.cockayne@mangopay.com>
…of the provider if not provided Signed-off-by: Matt Cockayne <matthew.cockayne@mangopay.com>
updates documentatoin to indicate optoinal values and defaults for providers Signed-off-by: Matt Cockayne <matthew.cockayne@mangopay.com>\ Signed-off-by: Matt Cockayne <matthew.cockayne@mangopay.com>
Signed-off-by: MH <zanhsieh@gmail.com>
zanhsieh
approved these changes
Jan 29, 2024
… lint checks Signed-off-by: Matt Cockayne <matthew.cockayne@mangopay.com>
zanhsieh
requested changes
Feb 2, 2024
Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Matt Cockayne <matthew.cockayne@mangopay.com>
closing as have been made aware that multi-org features are not being pursued |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converts
sidecar.dashboards.provider
to a list atsidecar.dashboards.providers
allowing the definition of multipleproviders that can be mappped to orgs as required.
still supports the singular variant to retain backwards compatibility
and will prepend it to any configured
providers
Results in multi-org support defining providers like the example below which
This then allows dashboard configmaps to be define the annotation
k8s-sidecar-target-directory: /tmp/dashboards/ops
instructing the sidecar to put the dashboard in the folder that's been specific in our configuration above.