[grafana] don't break ldap if admin is disabled #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes grafana#817 thanks @TomyLobo for flagging Signed-off-by: Naseem Ullah <24660299+naseemkullah@users.noreply.github.com>
naseemkullah
referenced
this pull request
Mar 2, 2022
Signed-off-by: naseemkullah <naseem@transit.app>
zanhsieh
approved these changes
Mar 3, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #817
thanks @TomyLobo for flagging
The secret can be in charge of both, either or none of admin credentials and ldap config.
If either ldap config or admin credential provisioning is applicable the secret is created, the content of the secret will vary depending on if admin credentials and/or ldap config require existence there
if neither ldap nor admin user are needed, the secret is not created