Page: add scrollbar ID to use in image renderer #88214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,7 @@ interface Props { | |||
| autoHeightMin?: number | string; | |||
| updateAfterMountMs?: number; | |||
| onScroll?: React.UIEventHandler; | |||
| divId?: string; | |||
There was a problem hiding this comment.
Does it finally work with id naming?
There was a problem hiding this comment.
No it doesn't, I think it clashes with the existing HTML attribute id.
juanicabanas
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds an ID to the main dashboard page scrollbar so we can rely on it in the image renderer instead of the class, which can be used in multiple places and could be more easily updated.
Special notes for your reviewer:
Works in combination with: grafana/grafana-image-renderer#524
Note that we will still support the class in the image renderer for a few versions to allow time for users to upgrade.