[Alerting] Avoid invalid characters in copied rule expression #57839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one! Should we add code comment saying we shouldn’t pass the readOnly prop and link it to this PR in case the next person who looks at this wants to add it? :) |
gillesdemey
approved these changes
Oct 28, 2022
Good idea! Done. |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/39824 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Allows to copy rule expressions without adding invalid characters in the pasted text.
Why do we need this feature?
Copying an expression and pasting it resulted in text that contained unwanted UTF-8 byte order mark characters.
Which issue(s) does this PR fix?:
Fixes #57610
Special notes for your reviewer:
Before:
After:
The issue happened when the
slate-react's Editor had thereadOnly=trueprop. Setting it tofalseprevents it from happening, but the editor is still non-editable regardless of that. The issue is reported in the Slate repo: ianstormtaylor/slate#2597