Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slo - capture plugin duration for http based plugins #998
slo - capture plugin duration for http based plugins #998
Changes from 2 commits
d2734d6
f60cc5b
098c134
05b285d
c382bc1
e2f617f
b26e263
fe90d2f
f73dcae
ee80a0b
0e470a4
1b31c0b
8e6eb0a
760ab11
2cd40dd
0fdc0cb
05c02e2
bbbf0e2
959eb10
0e485dc
bbb13a8
d9f70ad
0483689
c18ff82
ac58cca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Wonder if
status_code
is really needed, leave that up to you. But in general, feels like logs could be more suitable for details following our discussion from last week.