Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDC: Prioritize configuring TLS dialer from value fields over filepaths #970

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

wbrowne
Copy link
Member

@wbrowne wbrowne commented Apr 29, 2024

What this PR does / why we need it:
Value fields should be the priority when they are present in the request from Grafana.

Have manually tested for both Core and External plugins.

@wbrowne wbrowne self-assigned this Apr 29, 2024
@wbrowne wbrowne marked this pull request as ready for review April 29, 2024 11:13
@wbrowne wbrowne requested a review from a team as a code owner April 29, 2024 11:13
@wbrowne wbrowne requested review from marefr, andresmgot and xnyo and removed request for a team April 29, 2024 11:13
Copy link
Contributor

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wbrowne wbrowne merged commit d7ca26c into main Apr 30, 2024
3 checks passed
@wbrowne wbrowne deleted the pdc-filepaths-as-fallback branch April 30, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants