Security: can set array of auth tokens #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
commented
Apr 14, 2023
scripts/clean_target.sh
Outdated
There was a problem hiding this comment.
Adding this back as I'm not sure why it was deleted as it's still used in the Makefile.
undef1nd
approved these changes
Apr 14, 2023
spinillos
reviewed
Apr 14, 2023
spinillos
approved these changes
Apr 14, 2023
Co-authored-by: Selene <selenepinillos@gmail.com>
joanlopez
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To rotate authentication tokens in a distributed environment, updating the renderer token means breaking the rendering features in Grafana until the Grafana instances are updated with the right token.
Allowing to set up an array of authentication tokens allows to rotate tokens without downtime.
Notes: