Security: Add support for auth token #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent local file path rendering * Add support for SHARED_SECRET * Remove no longer needed check * Add URL check for gRPC requests * Always expect the auth token (both HTTP & gRPC) * Rename sharedSecret => authToken * Replace default authToken: '' => '-' * Handle gRPC errors properly
|
|
xlson
approved these changes
Aug 30, 2022
spinillos
approved these changes
Aug 30, 2022
(cherry picked from commit d9fc469)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new configurable token to make connections from Grafana through either HTTP API or gRPC more reliable and secure (allows us to check for reliable source of requests).
Which issue(s) this PR fixes:
Fixes CVE-2022-31176
Special notes for your reviewer: