-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #246
Upgrade dependencies #246
Conversation
if (!config.rendering.chromeBin && (process as any).pkg) { | ||
//@ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an issue with types, executablePath
works but TS complains that it doesn't exist.
Did some tests on Windows and it crashes when running in plugin mode because of this issue: puppeteer/puppeteer#6563.
I need to do more tests with the different options of the plugin but it looks good otherwise! |
@AgnesToulet are you able to fix the Windows issue? It's a bit hard for me to do as I don't have Windows machine setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested on Mac and it builds and works ok. Could use more tests on other OS probably.
Also did some brief profiling and it seems like total rendering time per panel is decreased by ~400ms, could be due to the newer versions of Chronium used.