Read custom cloud list from json string #141
Conversation
Bumps [github.com/grafana/grafana-plugin-sdk-go](https://github.com/grafana/grafana-plugin-sdk-go) from 0.219.0 to 0.230.0. - [Release notes](https://github.com/grafana/grafana-plugin-sdk-go/releases) - [Commits](grafana/grafana-plugin-sdk-go@v0.219.0...v0.230.0) --- updated-dependencies: - dependency-name: github.com/grafana/grafana-plugin-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
|
|
|
azsettings/settings.go
Outdated
| @@ -22,6 +22,8 @@ type AzureSettings struct { | |||
|
|
|||
| // This field determines which plugins will receive the settings via plugin context | |||
| ForwardSettingsPlugins []string | |||
|
|
|||
| customClouds []*AzureCloudSettings | |||
There was a problem hiding this comment.
I realized we may need to export this customClouds field after all - I was trying to keep it private to the package to push callers to use the functions, but inside grafana/grafana, we need to write this list back out as a json string when we push settings over to plugins via env variables. Thoughts?
There was a problem hiding this comment.
I think this should be fine to remain private for now. In grafana/grafana we can still call the Clouds or CustomClouds functions to retrieve the values.
There was a problem hiding this comment.
Clouds() and CustomClouds() return AzureCloudInfo struct, which does not have all the fields that are on AzureCloudSettings struct. grafana/grafana sometimes needs the extra info on AzureCloudSettings. I think we might eventually want to get rid of the AzureCloudInfo and just return the full set of fields in one struct. Callers can use the same set of methods for all use cases. If a caller doesn't need the additional fields, they can ingore them. Thoughts? For now, I was just leaning toward exporting customClouds. Thoughts?
There was a problem hiding this comment.
I'm fine with exporting the field for now, there's nothing that would be considered a secret in there afaict
TBH - I didn't notice exactly what is bringing in the dependency updates - I will try to clean those up if I can and still get it to build. |
…rom context fails
Looks like dependabot did the dependency updates, not me - see commit: https://github.com/grafana/grafana-azure-sdk-go/pull/141/commits |
This brings in the ability to specify the list of clouds from a json string, typically brought in through the grafana ini file. A seperate PR on grafana/grafana will add the ini file settings.