Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alertmanager subcommand and path for the configuration API #72

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

gotjosh
Copy link
Collaborator

@gotjosh gotjosh commented Aug 10, 2020

This PR fixes two things:

  • Seems like the Alertmanager subcommand got unregistered as we renamed it.
  • Uses the new Alertmanager path for the configuration API in accordance with what's in Cortex upstream.

Seems like it got unregistered as we renamed it.
In accordance with what is currently part of upstream Cortex.
@gotjosh gotjosh requested a review from a team as a code owner August 10, 2020 16:18
@gotjosh gotjosh requested a review from cstyan August 10, 2020 16:19
@gotjosh gotjosh merged commit 9f00599 into master Aug 10, 2020
@gotjosh gotjosh deleted the fix-am-commands branch August 10, 2020 18:35
simonswine pushed a commit to grafana/mimir that referenced this pull request Jan 12, 2022
…na/cortex-tools#72)

* Fix the alertmanager subcommand

Seems like it got unregistered as we renamed it.

* Use the new alertmanager API path.

In accordance with what is currently part of upstream Cortex.

* Add a changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants